Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add NewTypeKey derive macro #88

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

add NewTypeKey derive macro #88

wants to merge 5 commits into from

Conversation

dakom
Copy link

@dakom dakom commented Sep 25, 2024

No description provided.

@dakom dakom mentioned this pull request Sep 25, 2024
Open
uint
uint approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@uint uint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A couple nitpicks if you want them, but this delivers a perfectly good feature IMO.

macros/src/lib.rs Show resolved Hide resolved
macros/src/lib.rs Show resolved Hide resolved
tests/newtype.rs Show resolved Hide resolved
macros/src/newtype.rs Outdated Show resolved Hide resolved
macros/src/newtype.rs Outdated Show resolved Hide resolved
@dakom dakom requested a review from uint November 20, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uint uint Awaiting requested review from uint

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dakom @uint