Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Generate migrate entry point if message defined on contract #222

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

jawoznia
Copy link
Collaborator

No description provided.

@jawoznia jawoznia requested a review from hashedone September 18, 2023 15:54
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #222 (34e537e) into main (d1c0d6e) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #222      +/-   ##
==========================================
- Coverage   87.78%   87.72%   -0.07%     
==========================================
  Files          24       24              
  Lines        1302     1303       +1     
==========================================
  Hits         1143     1143              
- Misses        159      160       +1     
Files Changed Coverage Δ
sylvia-derive/src/message.rs 83.51% <0.00%> (-0.23%) ⬇️
sylvia/tests/messages_generation.rs 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jawoznia jawoznia force-pushed the generate_migrate_entry_point branch from c55379e to 694a40a Compare September 18, 2023 16:05
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would like to see tests for that.

The easiest way to verify that it is working is to add in one of the tests something like:

use entry_points::{instantiate, execute, query, migrate, reply};

You would do that for a single test that emits entry points. I checked manually they are correctly generated, but adding the verification wouldn't hurt.

@jawoznia jawoznia force-pushed the generate_migrate_entry_point branch from 694a40a to 34e537e Compare September 18, 2023 17:36
@jawoznia
Copy link
Collaborator Author

LGTM, but I would like to see tests for that.

The easiest way to verify that it is working is to add in one of the tests something like:

use entry_points::{instantiate, execute, query, migrate, reply};

You would do that for a single test that emits entry points. I checked manually they are correctly generated, but adding the verification wouldn't hurt.

Agree, but I think better way is to create cw_multi_test::ContractWrapper. This way we will also check if structure of these entry points is correct.

@jawoznia jawoznia merged commit e6131e4 into main Sep 18, 2023
5 of 7 checks passed
@jawoznia jawoznia deleted the generate_migrate_entry_point branch September 18, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants