Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support generic return types #234

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

jawoznia
Copy link
Collaborator

closes #225

@jawoznia jawoznia requested a review from hashedone September 22, 2023 14:36
@jawoznia jawoznia changed the base branch from main to feat/generics_support September 22, 2023 14:36
@jawoznia jawoznia changed the base branch from feat/generics_support to support_generic_interfaces September 22, 2023 14:37
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #234 (61039f4) into feat/generics_support (b9ba7ca) will increase coverage by 0.54%.
The diff coverage is 97.22%.

@@                    Coverage Diff                    @@
##           feat/generics_support     #234      +/-   ##
=========================================================
+ Coverage                  88.24%   88.79%   +0.54%     
=========================================================
  Files                         25       24       -1     
  Lines                       1336     1348      +12     
=========================================================
+ Hits                        1179     1197      +18     
+ Misses                       157      151       -6     
Files Coverage Δ
sylvia-derive/src/message.rs 86.48% <100.00%> (+1.66%) ⬆️
sylvia-derive/src/utils.rs 69.69% <87.50%> (+5.69%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jawoznia jawoznia force-pushed the support_generic_return_types branch 2 times, most recently from 5eb4c3f to 5cb244d Compare September 26, 2023 14:23
sylvia/tests/generics.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from support_generic_interfaces to feat/generics_support September 27, 2023 11:16
@jawoznia jawoznia force-pushed the support_generic_return_types branch from 8a4e97d to 61039f4 Compare September 27, 2023 11:19
@jawoznia jawoznia merged commit 1efa876 into feat/generics_support Sep 27, 2023
7 checks passed
@jawoznia jawoznia deleted the support_generic_return_types branch September 27, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support generics in interfaces return types
2 participants