Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interface extension trait #236

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Interface extension trait #236

merged 1 commit into from
Sep 28, 2023

Conversation

jawoznia
Copy link
Collaborator

@jawoznia jawoznia commented Sep 26, 2023 •
edited
Loading

closes #233

@jawoznia jawoznia requested a review from hashedone September 26, 2023 14:59
@jawoznia jawoznia changed the base branch from main to support_generic_return_types September 26, 2023 14:59
@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

Merging #236 (d7abd3b) into feat/generics_support (1efa876) will increase coverage by 0.25%.
The diff coverage is 95.83%.

@@                    Coverage Diff                    @@
##           feat/generics_support     #236      +/-   ##
=========================================================
+ Coverage                  88.79%   89.05%   +0.25%     
=========================================================
  Files                         24       24              
  Lines                       1348     1380      +32     
=========================================================
+ Hits                        1197     1229      +32     
  Misses                       151      151
Files Coverage Δ
sylvia-derive/src/input.rs 94.68% <100.00%> (+0.05%) ⬆️
sylvia-derive/src/utils.rs 69.69% <100.00%> (ø)
sylvia/src/types.rs 80.00% <ø> (ø)
sylvia-derive/src/message.rs 87.44% <95.65%> (+0.95%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jawoznia jawoznia force-pushed the interface_extension_trait branch from d695698 to 9b75928 Compare September 26, 2023 15:04
@jawoznia jawoznia force-pushed the support_generic_return_types branch from 8a4e97d to 61039f4 Compare September 27, 2023 11:19
@jawoznia jawoznia force-pushed the interface_extension_trait branch from 9b75928 to 8afdaca Compare September 27, 2023 11:21
@jawoznia jawoznia marked this pull request as ready for review September 27, 2023 11:21
Base automatically changed from support_generic_return_types to feat/generics_support September 27, 2023 13:04
@jawoznia jawoznia force-pushed the interface_extension_trait branch 2 times, most recently from dd4fd71 to d7abd3b Compare September 27, 2023 15:02
hashedone
hashedone approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jawoznia jawoznia merged commit eb685d4 into feat/generics_support Sep 28, 2023
7 checks passed
@jawoznia jawoznia deleted the interface_extension_trait branch September 28, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashedone hashedone hashedone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce the extension traits for the interface type
2 participants
@jawoznia @hashedone