Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support generic contract for simple contract #240

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

jawoznia
Copy link
Collaborator

@jawoznia jawoznia commented Oct 13, 2023

Part of #227

This change allows user to create simple Contract with generic instantiate.

Missing support for:

  • exec, query, migrate, reply generic messages
  • impl generic interface on generic contract
  • impl non-generic interface on generic contract

@jawoznia jawoznia force-pushed the simple_generic_contract branch 2 times, most recently from 9cbfa6c to 628114c Compare October 13, 2023 15:41
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #240 (2badc3a) into feat/generics_support (b2805a9) will decrease coverage by 0.94%.
The diff coverage is 80.93%.

@@                    Coverage Diff                    @@
##           feat/generics_support     #240      +/-   ##
=========================================================
- Coverage                  88.77%   87.83%   -0.94%     
=========================================================
  Files                         25       25              
  Lines                       1488     1595     +107     
=========================================================
+ Hits                        1321     1401      +80     
- Misses                       167      194      +27     
Files Coverage Δ
sylvia/tests/generics.rs 90.90% <100.00%> (+2.02%) ⬆️
sylvia-derive/src/input.rs 95.23% <97.77%> (-0.42%) ⬇️
sylvia-derive/src/parser.rs 82.69% <88.88%> (-0.41%) ⬇️
sylvia-derive/src/multitest.rs 94.16% <96.82%> (+1.27%) ⬆️
sylvia-derive/src/message.rs 83.56% <64.34%> (-3.80%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jawoznia jawoznia force-pushed the simple_generic_contract branch from 628114c to a91b3e7 Compare October 13, 2023 16:27
@jawoznia jawoznia force-pushed the support_multiple_generic_interfaces branch from b3b3c42 to 0775fa5 Compare October 18, 2023 11:21
@jawoznia jawoznia force-pushed the simple_generic_contract branch from a91b3e7 to d0edd45 Compare October 18, 2023 11:25
@jawoznia jawoznia force-pushed the support_multiple_generic_interfaces branch from 0775fa5 to 4e33f09 Compare October 19, 2023 10:43
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a small comment I believe you will fix

sylvia/tests/generics.rs Outdated Show resolved Hide resolved
@jawoznia jawoznia force-pushed the support_multiple_generic_interfaces branch from 4e33f09 to 246cba3 Compare October 19, 2023 13:24
Base automatically changed from support_multiple_generic_interfaces to feat/generics_support October 19, 2023 13:44
@jawoznia jawoznia force-pushed the simple_generic_contract branch from d0edd45 to 2badc3a Compare October 19, 2023 13:48
@jawoznia jawoznia merged commit 3d78b45 into feat/generics_support Oct 19, 2023
5 of 7 checks passed
@jawoznia jawoznia deleted the simple_generic_contract branch October 19, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants