Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove MessageSignature from multitest #241

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

jawoznia
Copy link
Collaborator

No description provided.

@jawoznia jawoznia force-pushed the remove_message_signature branch from 3b28694 to 7b4ae63 Compare October 16, 2023 14:27
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #241 (595cf2b) into feat/generics_support (3d78b45) will increase coverage by 0.84%.
The diff coverage is 97.88%.

@@                    Coverage Diff                    @@
##           feat/generics_support     #241      +/-   ##
=========================================================
+ Coverage                  87.83%   88.68%   +0.84%     
=========================================================
  Files                         25       25              
  Lines                       1595     1670      +75     
=========================================================
+ Hits                        1401     1481      +80     
+ Misses                       194      189       -5     
Files Coverage Δ
sylvia-derive/src/multitest.rs 97.19% <100.00%> (+3.02%) ⬆️
sylvia-derive/src/message.rs 85.78% <97.02%> (+2.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jawoznia jawoznia force-pushed the simple_generic_contract branch from a91b3e7 to d0edd45 Compare October 18, 2023 11:25
@jawoznia jawoznia force-pushed the remove_message_signature branch from 7b4ae63 to 4435a57 Compare October 18, 2023 11:27
@hashedone
Copy link
Collaborator

What is this change purpose?

@jawoznia jawoznia force-pushed the simple_generic_contract branch from d0edd45 to 2badc3a Compare October 19, 2023 13:48
Base automatically changed from simple_generic_contract to feat/generics_support October 19, 2023 14:09
@jawoznia
Copy link
Collaborator Author

What is this change purpose?

This change is not connected directly to the feature but I found it troublesome at some points to work with the original design. I decided to smuggle this small refactor in this feature to ease the further development and to rely on it in future refactor.

Before merge to main I will squash this commit to not pollute commit history with chore.

@jawoznia jawoznia force-pushed the remove_message_signature branch from 4435a57 to 595cf2b Compare October 19, 2023 14:18
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, Then LGTM.
Thank you for doing it in its separate PR. Appreciate it.

@jawoznia jawoznia merged commit d86680b into feat/generics_support Oct 23, 2023
7 checks passed
@jawoznia jawoznia deleted the remove_message_signature branch October 23, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants