Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Wrap impl types in sv module #246

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

jawoznia
Copy link
Collaborator

@jawoznia jawoznia commented Oct 25, 2023

part of #114

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #246 (d6385b0) into feat/generics_support (e255585) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@                    Coverage Diff                    @@
##           feat/generics_support     #246      +/-   ##
=========================================================
+ Coverage                  85.85%   85.87%   +0.02%     
=========================================================
  Files                         24       24              
  Lines                       1654     1657       +3     
=========================================================
+ Hits                        1420     1423       +3     
  Misses                       234      234              
Files Coverage Δ
sylvia-derive/src/input.rs 93.10% <100.00%> (+0.12%) ⬆️
sylvia/tests/custom_msg.rs 100.00% <ø> (ø)
sylvia/tests/custom_query.rs 92.00% <ø> (ø)
sylvia/tests/querier.rs 96.66% <100.00%> (+0.11%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jawoznia jawoznia force-pushed the generate_iface_types_in_sv_module branch from c1bba34 to 86e304e Compare October 27, 2023 15:19
Base automatically changed from generate_iface_types_in_sv_module to feat/generics_support October 27, 2023 18:52
@jawoznia jawoznia force-pushed the generate_impl_types_in_sv_module branch from ba0fe74 to d6385b0 Compare October 27, 2023 18:54
@jawoznia jawoznia merged commit 88ca546 into feat/generics_support Oct 30, 2023
7 checks passed
@jawoznia jawoznia deleted the generate_impl_types_in_sv_module branch October 30, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants