Contract api #248
Merged
Contract api #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jawoznia
changed the base branch from
main
to
generate_contract_types_in_sv_module
Codecov Report
@@ Coverage Diff @@
## feat/generics_support #248 +/- ##
=========================================================
+ Coverage 85.87% 87.02% +1.14%
=========================================================
Files 24 25 +1
Lines 1657 1726 +69
=========================================================
+ Hits 1423 1502 +79
+ Misses 234 224 -10
... and 2 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
jawoznia
force-pushed
the
contract_api
branch
2 times, most recently
from
09c3158 to
9bab234
Compare
jawoznia
commented
Oct 26, 2023
jawoznia
force-pushed
the
generate_contract_types_in_sv_module
branch
from
8f840c3 to
25500b7
Compare
Base automatically changed from
generate_contract_types_in_sv_module
to
feat/generics_support
October 30, 2023 10:58
jawoznia
force-pushed
the
contract_api
branch
from
9bab234 to
2e4a7ac
Compare
jawoznia
force-pushed
the
contract_api
branch
from
2e4a7ac to
c653e88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impl Extension trait on Contract. This change is required to generate
entry_points without requiring user to specify which generics are for which messages.Unfortunately rust compiler requires fully-qualified path and in current state it's not the most user friendly Api so the primary use case is code generation.
#86