Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support generic types in entry points #249

Merged
merged 2 commits into from
Nov 13, 2023
Merged

feat: Support generic types in entry points #249

merged 2 commits into from
Nov 13, 2023

Conversation

jawoznia
Copy link
Collaborator

close #228

@jawoznia jawoznia force-pushed the generics_in_entry_points branch from 83701e5 to 9ff90a9 Compare October 26, 2023 12:55
@codecov
Copy link

codecov bot commented Oct 26, 2023 •
edited
Loading

Codecov Report

Merging #249 (7c40662) into feat/generics_support (ea75996) will decrease coverage by 0.81%.
The diff coverage is 12.90%.

@@                    Coverage Diff                    @@
##           feat/generics_support     #249      +/-   ##
=========================================================
- Coverage                  87.02%   86.21%   -0.81%     
=========================================================
  Files                         25       25              
  Lines                       1726     1741      +15     
=========================================================
- Hits                        1502     1501       -1     
- Misses                       224      240      +16
Files Coverage Δ
sylvia-derive/src/interfaces.rs 86.86% <100.00%> (ø)
sylvia-derive/src/lib.rs 100.00% <ø> (ø)
sylvia-derive/src/message.rs 84.82% <14.28%> (-0.25%) ⬇️
sylvia-derive/src/parser.rs 76.36% <6.25%> (-5.28%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@jawoznia jawoznia force-pushed the generics_in_entry_points branch from 9ff90a9 to 6ad43ab Compare October 30, 2023 13:43
hashedone
hashedone approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from contract_api to feat/generics_support November 13, 2023 10:32
@jawoznia jawoznia force-pushed the generics_in_entry_points branch 2 times, most recently from a6169b7 to aeec1ff Compare November 13, 2023 10:40
@jawoznia jawoznia mentioned this pull request Nov 13, 2023
Closed
@jawoznia jawoznia force-pushed the generics_in_entry_points branch from aeec1ff to 7c40662 Compare November 13, 2023 10:54
@jawoznia jawoznia merged commit 25df909 into feat/generics_support Nov 13, 2023
5 of 7 checks passed
@jawoznia jawoznia deleted the generics_in_entry_points branch November 13, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashedone hashedone hashedone approved these changes

@DariuszDepta DariuszDepta Awaiting requested review from DariuszDepta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jawoznia @hashedone