Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Generic support #253

Merged
merged 15 commits into from
Nov 13, 2023
Merged

feat: Generic support #253

merged 15 commits into from
Nov 13, 2023

Conversation

jawoznia
Copy link
Collaborator

No description provided.

@jawoznia jawoznia requested a review from hashedone November 13, 2023 11:17
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #253 (58ad1ac) into main (05c0572) will decrease coverage by 1.57%.
The diff coverage is 83.65%.

@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
- Coverage   87.74%   86.18%   -1.57%     
==========================================
  Files          24       25       +1     
  Lines        1306     1744     +438     
==========================================
+ Hits         1146     1503     +357     
- Misses        160      241      +81     
Files Coverage Δ
sylvia-derive/src/lib.rs 100.00% <ø> (ø)
sylvia-derive/src/remote.rs 100.00% <100.00%> (ø)
sylvia/src/into_response.rs 100.00% <100.00%> (ø)
sylvia/src/types.rs 80.00% <ø> (ø)
sylvia/tests/custom_msg.rs 100.00% <ø> (ø)
sylvia/tests/custom_query.rs 92.00% <ø> (ø)
sylvia/tests/dispatching.rs 93.33% <100.00%> (ø)
sylvia/tests/entry_points.rs 100.00% <ø> (ø)
sylvia/tests/messages_generation.rs 0.00% <ø> (ø)
sylvia/tests/querier.rs 96.66% <100.00%> (+0.11%) ⬆️
... and 10 more

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@jawoznia jawoznia force-pushed the feat/generics_support branch from 25df909 to 58ad1ac Compare November 13, 2023 11:25
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jawoznia jawoznia merged commit cc11f29 into main Nov 13, 2023
9 of 11 checks passed
@jawoznia jawoznia deleted the feat/generics_support branch November 13, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants