Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Describe generics support in README.md #254

Merged
merged 2 commits into from
Nov 20, 2023
Merged

docs: Describe generics support in README.md #254

merged 2 commits into from
Nov 20, 2023

Conversation

jawoznia
Copy link
Collaborator

@jawoznia jawoznia commented Nov 13, 2023 •
edited
Loading

close #229

@codecov Codecov
Copy link

codecov bot commented Nov 13, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c6b0975) 86.18% compared to head (3f88119) 86.18%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #254   +/-   ##
=======================================
  Coverage   86.18%   86.18%           
=======================================
  Files          25       25           
  Lines        1744     1744           
=======================================
  Hits         1503     1503           
  Misses        241      241

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

costa2400
costa2400 approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@costa2400 costa2400 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit changes and addition to the generics/generics interface to sylvia

@jawoznia
Copy link
Collaborator Author

Edit changes and addition to the generics/generics interface to sylvia

Please point to the exact line where the problem is.

hashedone
hashedone approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jawoznia jawoznia merged commit d1c69d8 into main Nov 20, 2023
7 checks passed
@jawoznia jawoznia deleted the describe_generics branch November 20, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costa2400 costa2400 costa2400 approved these changes

@hashedone hashedone hashedone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update docs about generics support
3 participants
@jawoznia @hashedone @costa2400