Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Generate SudoMsg in interface #255

Merged
merged 1 commit into from
Nov 16, 2023
Merged

feat: Generate SudoMsg in interface #255

merged 1 commit into from
Nov 16, 2023

Conversation

jawoznia
Copy link
Collaborator

@jawoznia jawoznia commented Nov 15, 2023 •
edited
Loading

@jawoznia jawoznia requested a review from hashedone November 15, 2023 13:56
@codecov Codecov
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (23f072c) 86.18% compared to head (1713606) 86.16%.

Files Patch % Lines
sylvia-derive/src/message.rs 66.66% 2 Missing ⚠️
sylvia-derive/src/parser.rs 80.00% 1 Missing ⚠️
sylvia/src/types.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##           feat/sudo     #255      +/-   ##
=============================================
- Coverage      86.18%   86.16%   -0.02%     
=============================================
  Files             25       25              
  Lines           1744     1749       +5     
=============================================
+ Hits            1503     1507       +4     
- Misses           241      242       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hashedone
hashedone approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jawoznia jawoznia merged commit 1aab02b into feat/sudo Nov 16, 2023
5 of 7 checks passed
@jawoznia jawoznia deleted the interface_with_sudo branch November 16, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashedone hashedone hashedone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jawoznia @hashedone