Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow generic return type in contract queries #256

Closed
wants to merge 1 commit into from

Conversation

jawoznia
Copy link
Collaborator

No description provided.

@jawoznia jawoznia requested a review from hashedone November 15, 2023 14:23
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d1c69d8) 86.52% compared to head (56021f3) 86.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
+ Coverage   86.52%   86.66%   +0.13%     
==========================================
  Files          24       24              
  Lines        1737     1755      +18     
==========================================
+ Hits         1503     1521      +18     
  Misses        234      234              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not really sure which test is testing the generic ret type in queries, what do I miss?

Base automatically changed from describe_generics to main November 20, 2023 11:07
@jawoznia jawoznia force-pushed the generic_return_type_in_contract branch from 632895b to 56021f3 Compare November 20, 2023 11:08
@jawoznia
Copy link
Collaborator Author

closing in favor of #264

@jawoznia jawoznia closed this Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants