Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow specifying salt for contract address #259

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

jawoznia
Copy link
Collaborator

No description provided.

@jawoznia jawoznia requested a review from hashedone November 16, 2023 16:19
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d1c69d8) 86.52% compared to head (ff1d6ce) 86.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
+ Coverage   86.52%   86.55%   +0.02%     
==========================================
  Files          24       25       +1     
  Lines        1737     1740       +3     
==========================================
+ Hits         1503     1506       +3     
  Misses        234      234              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jawoznia jawoznia force-pushed the support_instantiate2 branch 2 times, most recently from 51c4e56 to 36d39b4 Compare November 16, 2023 17:26
Base automatically changed from update_deps to main November 17, 2023 09:56
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature management has to improve

sylvia/Cargo.toml Outdated Show resolved Hide resolved
@jawoznia jawoznia force-pushed the support_instantiate2 branch 4 times, most recently from dd1c7c3 to 2986d45 Compare November 17, 2023 11:48
@jawoznia jawoznia force-pushed the support_instantiate2 branch from 2986d45 to ff1d6ce Compare November 20, 2023 11:08
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly ok, but consider falling back to instantiate instead of hard error when using salt pre-1.2

sylvia-derive/src/multitest.rs Show resolved Hide resolved
@jawoznia jawoznia merged commit 2c734f5 into main Nov 29, 2023
7 checks passed
@jawoznia jawoznia deleted the support_instantiate2 branch November 29, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants