Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl sudo interface #268

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Impl sudo interface #268

merged 1 commit into from
Nov 30, 2023

Conversation

jawoznia
Copy link
Collaborator

part of #252

Simple example in sylvia/tests confirming that sudo interface can be implemented on contract

@jawoznia jawoznia requested a review from hashedone November 24, 2023 12:29
@jawoznia jawoznia changed the base branch from main to feat/sudo November 24, 2023 12:30
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9639341) 86.71% compared to head (f5090f0) 86.85%.

Additional details and impacted files
@@              Coverage Diff              @@
##           feat/sudo     #268      +/-   ##
=============================================
+ Coverage      86.71%   86.85%   +0.13%     
=============================================
  Files             24       24              
  Lines           1769     1780      +11     
=============================================
+ Hits            1534     1546      +12     
+ Misses           235      234       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jawoznia jawoznia force-pushed the impl_sudo_interface branch 2 times, most recently from 385ee8b to c739c8a Compare November 24, 2023 13:57
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, but I would like to make the contract internals a proper state

sylvia/tests/dispatching.rs Outdated Show resolved Hide resolved
@jawoznia jawoznia force-pushed the impl_sudo_interface branch 3 times, most recently from d66bbdb to f5090f0 Compare November 29, 2023 17:49
@jawoznia jawoznia merged commit 520bf3c into feat/sudo Nov 30, 2023
7 checks passed
@jawoznia jawoznia deleted the impl_sudo_interface branch November 30, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants