Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sudo entry point #269

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Sudo entry point #269

merged 1 commit into from
Nov 30, 2023

Conversation

jawoznia
Copy link
Collaborator

part of #252

@jawoznia jawoznia requested a review from hashedone November 24, 2023 13:41
@jawoznia jawoznia changed the base branch from main to impl_sudo_interface November 24, 2023 13:50
@jawoznia jawoznia force-pushed the impl_sudo_interface branch from 385ee8b to c739c8a Compare November 24, 2023 13:57
@jawoznia jawoznia force-pushed the sudo_entry_point branch 2 times, most recently from 8243458 to ae6d87d Compare November 24, 2023 15:24
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like this level of testing.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (520bf3c) 86.85% compared to head (b5112dc) 86.80%.

Files Patch % Lines
sylvia-derive/src/message.rs 0.00% 2 Missing ⚠️
sylvia/tests/entry_points.rs 94.73% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           feat/sudo     #269      +/-   ##
=============================================
- Coverage      86.85%   86.80%   -0.05%     
=============================================
  Files             24       24              
  Lines           1780     1796      +16     
=============================================
+ Hits            1546     1559      +13     
- Misses           234      237       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jawoznia jawoznia force-pushed the impl_sudo_interface branch from 836505e to d66bbdb Compare November 29, 2023 17:46
@jawoznia jawoznia force-pushed the impl_sudo_interface branch from d66bbdb to f5090f0 Compare November 29, 2023 17:49
Base automatically changed from impl_sudo_interface to feat/sudo November 30, 2023 08:01
@jawoznia jawoznia merged commit 22d89c5 into feat/sudo Nov 30, 2023
@jawoznia jawoznia deleted the sudo_entry_point branch November 30, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants