Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concretes in entry points #276

Closed
wants to merge 5 commits into from
Closed

Concretes in entry points #276

wants to merge 5 commits into from

Conversation

jawoznia
Copy link
Collaborator

@jawoznia jawoznia commented Dec 7, 2023

@jawoznia jawoznia requested a review from hashedone December 7, 2023 14:49
@codecov Codecov
Copy link

codecov bot commented Dec 7, 2023 •
edited
Loading

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (c245395) 87.32% compared to head (942f369) 86.55%.

Files Patch % Lines
sylvia-derive/src/parser.rs 0.00% 19 Missing ⚠️
sylvia-derive/src/message.rs 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@                     Coverage Diff                      @@
##           feat/generics_forwarding     #276      +/-   ##
============================================================
- Coverage                     87.32%   86.55%   -0.77%     
============================================================
  Files                            25       25              
  Lines                          1814     1830      +16     
============================================================
  Hits                           1584     1584              
- Misses                          230      246      +16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jawoznia jawoznia changed the base branch from main to duplicated_queries December 7, 2023 15:01
hashedone
hashedone approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jawoznia jawoznia force-pushed the duplicated_queries branch 2 times, most recently from c5af382 to c62acb1 Compare December 20, 2023 12:34
Base automatically changed from duplicated_queries to feat/generics_forwarding December 20, 2023 12:51
@jawoznia jawoznia force-pushed the concretes_in_entry_points branch from 4a6f63e to 942f369 Compare December 20, 2023 13:11
@jawoznia jawoznia closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashedone hashedone hashedone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jawoznia @hashedone