Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Impl interface with associated types on non generic contract #282

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

jawoznia
Copy link
Collaborator

No description provided.

@jawoznia jawoznia requested a review from hashedone January 11, 2024 20:56
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (30a6a0e) 81.48% compared to head (8d0fead) 80.94%.

Files Patch % Lines
sylvia-derive/src/querier.rs 73.33% 8 Missing ⚠️
sylvia-derive/src/strip_self_path.rs 66.66% 3 Missing ⚠️
sylvia-derive/src/multitest.rs 90.47% 2 Missing ⚠️
sylvia-derive/src/associated_types.rs 94.11% 1 Missing ⚠️
sylvia-derive/src/message.rs 96.29% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           feat/generics_forwarding     #282      +/-   ##
============================================================
- Coverage                     81.48%   80.94%   -0.54%     
============================================================
  Files                            28       28              
  Lines                          1923     1958      +35     
============================================================
+ Hits                           1567     1585      +18     
- Misses                          356      373      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sylvia-derive/src/message.rs Show resolved Hide resolved
sylvia-derive/src/remote.rs Show resolved Hide resolved
@jawoznia jawoznia force-pushed the asso_types_interfaces branch from 9ccf99e to 4124c47 Compare January 24, 2024 11:39
@kulikthebird kulikthebird mentioned this pull request Jan 31, 2024
1 task
Base automatically changed from asso_types_interfaces to feat/generics_forwarding January 31, 2024 12:07
@jawoznia jawoznia force-pushed the asso_types_impl_interface branch from 508a7fc to 8d0fead Compare January 31, 2024 12:18
@jawoznia jawoznia merged commit 612df7a into feat/generics_forwarding Jan 31, 2024
6 of 7 checks passed
@jawoznia jawoznia deleted the asso_types_impl_interface branch January 31, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants