Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make as Variant optional for #[messages(...)] attribtue #288

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

kulikthebird
Copy link
Contributor

No description provided.

@kulikthebird kulikthebird requested a review from jawoznia January 18, 2024 16:57
@kulikthebird kulikthebird self-assigned this Jan 18, 2024
@kulikthebird kulikthebird linked an issue Jan 18, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (711508b) 86.57% compared to head (4a6ec41) 86.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #288   +/-   ##
=======================================
  Coverage   86.57%   86.57%           
=======================================
  Files          25       25           
  Lines        1773     1773           
=======================================
  Hits         1535     1535           
  Misses        238      238           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kulikthebird kulikthebird force-pushed the message_attr_improvement branch 2 times, most recently from 7ccd2e5 to 36d42af Compare January 22, 2024 15:57
@kulikthebird kulikthebird force-pushed the message_attr_improvement branch from 36d42af to 5e50f4d Compare January 22, 2024 16:25
Copy link
Collaborator

@jawoznia jawoznia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider better error messages. Otherwise LGTM.

sylvia-derive/src/parser.rs Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
sylvia-derive/src/parser.rs Outdated Show resolved Hide resolved
@kulikthebird kulikthebird force-pushed the message_attr_improvement branch 2 times, most recently from 9a9902e to 9be418c Compare January 24, 2024 16:40
@kulikthebird kulikthebird force-pushed the message_attr_improvement branch from 9be418c to 4a6ec41 Compare January 24, 2024 17:35
@jawoznia jawoznia mentioned this pull request Jan 25, 2024
1 task
@kulikthebird kulikthebird merged commit 7fe53ea into main Jan 31, 2024
7 checks passed
@kulikthebird kulikthebird deleted the message_attr_improvement branch January 31, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make as Variant optional for #[messages(...)] attribtue
2 participants