Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor struct message generation #412

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Conversation

jawoznia
Copy link
Collaborator

@jawoznia jawoznia commented Aug 6, 2024

No description provided.

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 75.43860% with 14 lines in your changes missing coverage. Please review.

Project coverage is 82.24%. Comparing base (4c5a678) to head (3263d69).

Files Patch % Lines
...ia-derive/src/contract/communication/struct_msg.rs 76.59% 11 Missing ⚠️
sylvia-derive/src/parser/mod.rs 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
- Coverage   82.30%   82.24%   -0.06%     
==========================================
  Files          53       53              
  Lines        3113     3098      -15     
==========================================
- Hits         2562     2548      -14     
+ Misses        551      550       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kulikthebird kulikthebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only one comment related to the change of the generated message structure. Also it seems like this change can be breaking

@jawoznia jawoznia merged commit 0fa70ee into main Aug 9, 2024
7 of 9 checks passed
@jawoznia jawoznia deleted the jawoznia/further_refactor branch August 9, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants