Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Auto deserialize payload #440

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

jawoznia
Copy link
Collaborator

@jawoznia jawoznia commented Oct 8, 2024

No description provided.

@jawoznia jawoznia requested a review from kulikthebird October 8, 2024 12:49
@jawoznia jawoznia linked an issue Oct 8, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 92.68293% with 9 lines in your changes missing coverage. Please review.

Project coverage is 72.41%. Comparing base (9e28aeb) to head (d9b3a63).
Report is 3 commits behind head on feat/replies.

Files with missing lines Patch % Lines
sylvia-derive/src/contract/communication/reply.rs 95.49% 5 Missing ⚠️
sylvia-derive/src/parser/attributes/mod.rs 20.00% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           feat/replies     #440      +/-   ##
================================================
+ Coverage         72.18%   72.41%   +0.22%     
================================================
  Files                56       56              
  Lines              3484     3542      +58     
================================================
+ Hits               2515     2565      +50     
- Misses              969      977       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jawoznia jawoznia force-pushed the jawoznia/feat/admin_management_through_remote branch from 3aa9968 to 789266f Compare October 9, 2024 16:23
@jawoznia jawoznia force-pushed the jawoznia/feat/deserialize_payload branch from 7cfccf7 to c5ee0d8 Compare October 9, 2024 16:24
@jawoznia jawoznia force-pushed the jawoznia/feat/admin_management_through_remote branch from 789266f to 6fb6049 Compare October 11, 2024 14:20
Base automatically changed from jawoznia/feat/admin_management_through_remote to feat/replies October 11, 2024 14:34
@jawoznia jawoznia force-pushed the jawoznia/feat/deserialize_payload branch from c5ee0d8 to d9b3a63 Compare October 11, 2024 14:36
Copy link
Contributor

@kulikthebird kulikthebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only one comment here from me. Also it's worth to take a look into reply.rs src file before merging this feature into main. Maybe there's a chance to make the code more compact in this case

sylvia/tests/reply.rs Show resolved Hide resolved
@jawoznia jawoznia merged commit fb86aaa into feat/replies Oct 14, 2024
9 checks passed
@jawoznia jawoznia deleted the jawoznia/feat/deserialize_payload branch October 14, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto payload deserialization
2 participants