Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for sv::features attribute. (#446) #447

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

jawoznia
Copy link
Collaborator

Remove sv_replies feature as it does not make the change non breaking.

closes #446

@jawoznia jawoznia linked an issue Oct 15, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 65.62500% with 11 lines in your changes missing coverage. Please review.

Project coverage is 71.95%. Comparing base (d43909d) to head (d3faa82).
Report is 2 commits behind head on feat/replies.

Files with missing lines Patch % Lines
sylvia-derive/src/parser/attributes/features.rs 64.70% 6 Missing ⚠️
sylvia-derive/src/entry_points.rs 0.00% 4 Missing ⚠️
sylvia-derive/src/contract/mt.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           feat/replies     #447      +/-   ##
================================================
- Coverage         72.18%   71.95%   -0.23%     
================================================
  Files                56       59       +3     
  Lines              3577     3634      +57     
================================================
+ Hits               2582     2615      +33     
- Misses              995     1019      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Remove `sv_replies` feature as it does not make the change non breaking.
@jawoznia jawoznia force-pushed the jawoznia/feat/add_features_attribute branch from aca6bf8 to 689607c Compare October 15, 2024 14:34
Copy link
Contributor

@kulikthebird kulikthebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this approach!

sylvia/tests/ui/attributes/features/invalid_params.stderr Outdated Show resolved Hide resolved
sylvia-derive/src/lib.rs Outdated Show resolved Hide resolved
@jawoznia jawoznia force-pushed the jawoznia/feat/add_features_attribute branch from b7b32c2 to d3faa82 Compare October 16, 2024 13:25
@jawoznia jawoznia merged commit b043037 into feat/replies Oct 16, 2024
7 of 9 checks passed
@jawoznia jawoznia deleted the jawoznia/feat/add_features_attribute branch October 16, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sv::features attribute to avoid breaking API
2 participants