Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add auto deserialization of reply data (#445) #448

Open
wants to merge 2 commits into
base: feat/replies
Choose a base branch
from

Conversation

jawoznia
Copy link
Collaborator

No description provided.

@jawoznia jawoznia force-pushed the jawoznia/feat/data_deserialization branch from 8c509ad to e42fc9e Compare October 18, 2024 14:07
@jawoznia jawoznia force-pushed the jawoznia/feat/data_deserialization branch from e42fc9e to c580365 Compare October 21, 2024 14:00
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 16 lines in your changes missing coverage. Please review.

Project coverage is 72.48%. Comparing base (b043037) to head (fb28493).

Files with missing lines Patch % Lines
sylvia-derive/src/parser/attributes/data.rs 62.96% 10 Missing ⚠️
sylvia-derive/src/contract/communication/reply.rs 93.10% 4 Missing ⚠️
sylvia/tests/reply_data.rs 94.73% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           feat/replies     #448      +/-   ##
================================================
+ Coverage         71.95%   72.48%   +0.52%     
================================================
  Files                59       61       +2     
  Lines              3634     3762     +128     
================================================
+ Hits               2615     2727     +112     
- Misses             1019     1035      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jawoznia jawoznia marked this pull request as ready for review October 21, 2024 14:32
@jawoznia jawoznia linked an issue Oct 22, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto deserialize data
1 participant