Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename ReplyOn::Failure to match variant from std #449

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

jawoznia
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.49%. Comparing base (3c89bcc) to head (d57d49f).
Report is 1 commits behind head on feat/replies.

Files with missing lines Patch % Lines
sylvia-derive/src/parser/attributes/msg.rs 33.33% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           feat/replies     #449   +/-   ##
=============================================
  Coverage         72.49%   72.49%           
=============================================
  Files                62       62           
  Lines              3795     3795           
=============================================
  Hits               2751     2751           
  Misses             1044     1044           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jawoznia jawoznia force-pushed the jawoznia/chore/rename_reply_on_failure branch from 4f7f456 to b6cb2ca Compare October 22, 2024 07:36
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, important change.

Base automatically changed from jawoznia/feat/data_deserialization to feat/replies October 31, 2024 11:30
@jawoznia jawoznia force-pushed the jawoznia/chore/rename_reply_on_failure branch from b6cb2ca to d57d49f Compare October 31, 2024 11:32
@jawoznia jawoznia merged commit 0df5cf9 into feat/replies Oct 31, 2024
9 checks passed
@jawoznia jawoznia deleted the jawoznia/chore/rename_reply_on_failure branch October 31, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants