Use Uint64 for BlockInfo Time

CosmWasm · Nov 15, 2023 · 3f0224c · 3f0224c
1 parent 6daf8e4
commit 3f0224c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/spec/Specification.md b/spec/Specification.md
@@ -81,8 +81,8 @@ type Params struct {
 type BlockInfo struct {
 	// block height this transaction is executed
 	Height uint64 `json:"height"`
-	// time in nanoseconds since unix epoch. Uses string to ensure JavaScript compatibility.
-	Time    uint64 `json:"time,string"`
+	// time in nanoseconds since unix epoch. Uses Uint64 to ensure JavaScript compatibility.
+	Time    Uint64 `json:"time"`
 	ChainID string `json:"chain_id"`
 }
 

diff --git a/types/env.go b/types/env.go
@@ -16,8 +16,8 @@ type Env struct {
 type BlockInfo struct {
 	// block height this transaction is executed
 	Height uint64 `json:"height"`
-	// time in nanoseconds since unix epoch. Uses string to ensure JavaScript compatibility.
-	Time    uint64 `json:"time,string"`
+	// time in nanoseconds since unix epoch. Uses Uint64 to ensure JavaScript compatibility.
+	Time    Uint64 `json:"time"`
 	ChainID string `json:"chain_id"`
 }
 

diff --git a/types/env_test.go b/types/env_test.go
@@ -92,5 +92,5 @@ func TestBlockInfoDeserialization(t *testing.T) {
 
 	// Empty string is not a valid uint64 string
 	err = json.Unmarshal([]byte(`{"height":0,"time":"","chain_id":""}`), &block)
-	require.ErrorContains(t, err, "invalid use of ,string struct tag, trying to unmarshal \"\" into uint64")
+	require.ErrorContains(t, err, "cannot unmarshal \"\" into Uint64, expected string-encoded integer")
 }