Merge pull request #543 from CosmWasm/co/fix-errorWithMessage

Fix `errorWithMessage`
CosmWasm · Jun 26, 2024 · 73b87c0 · 73b87c0
2 parents caa4c0f + a716026
commit 73b87c0
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/internal/api/lib.go b/internal/api/lib.go
@@ -796,11 +796,13 @@ func convertGasReport(report C.GasReport) types.GasReport {
 /**** To error module ***/
 
 func errorWithMessage(err error, b C.UnmanagedVector) error {
+	// we always destroy the unmanaged vector to avoid a memory leak
+	msg := copyAndDestroyUnmanagedVector(b)
+
 	// this checks for out of gas as a special case
 	if errno, ok := err.(syscall.Errno); ok && int(errno) == 2 {
 		return types.OutOfGasError{}
 	}
-	msg := copyAndDestroyUnmanagedVector(b)
 	if msg == nil {
 		return err
 	}