Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return full gas report to wasmd #448

Closed
wants to merge 2 commits into from
Closed

Return full gas report to wasmd #448

wants to merge 2 commits into from

Conversation

chipshort
Copy link
Collaborator

@chipshort chipshort commented Aug 16, 2023 •
edited
Loading

This adjusts the entry points to take a pointer to the full gas report.
I'll integrate it into the go side when this is merged and the new library is built.

webmaster128
webmaster128 reviewed Aug 16, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We also need to update the caller code (Go) of the changed functions in internal/api

libwasmvm/src/gas_report.rs Outdated Show resolved Hide resolved
libwasmvm/bindings.h Outdated Show resolved Hide resolved
webmaster128
webmaster128 reviewed Aug 16, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We might need to use this PR branch for the reproduction of the issue though due to the API breaking change.

lib.go Show resolved Hide resolved
libwasmvm/src/gas_report.rs Outdated Show resolved Hide resolved
@chipshort chipshort mentioned this pull request Aug 17, 2023
Merged
@chipshort chipshort changed the base branch from main to gas-report-part1 August 17, 2023 11:52
@chipshort chipshort changed the title Return full gas report to go side Return full gas report to wasmd Aug 17, 2023
Base automatically changed from gas-report-part1 to main August 22, 2023 09:11
@webmaster128 webmaster128 mentioned this pull request Aug 22, 2023
Closed
@chipshort
Copy link
Collaborator Author

Closing this, as we don't need to return all this information to wasmd

@chipshort chipshort closed this Aug 24, 2023
@webmaster128 webmaster128 deleted the full-gas-report branch August 24, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chipshort @webmaster128