-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Go dev environment from Alpine builder #480
Conversation
I tested the changed Docker image (Alpine without Go) locally. It works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, as far as I can tell
create-tester-image: | ||
docker build -t $(ALPINE_TESTER) - < ./Dockerfile.alpine_tester | ||
|
||
test-alpine: release-build-alpine create-tester-image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On my Macbook test-alpine fails with an error about incompatible libwasmvm_muslc.a (during the go build -tags muslc ./...
. Any idea why?
/usr/local/go/pkg/tool/linux_arm64/link: running gcc failed: exit status 1
/usr/lib/gcc/aarch64-alpine-linux-musl/12.2.1/../../../../aarch64-alpine-linux-musl/bin/ld: skipping incompatible /mnt/testrun/internal/api/libwasmvm_muslc.a when searching for -lwasmvm_muslc
/usr/lib/gcc/aarch64-alpine-linux-musl/12.2.1/../../../../aarch64-alpine-linux-musl/bin/ld: cannot find -lwasmvm_muslc: No such file or directory
collect2: error: ld returned 1 exit status
I guess it's platform issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, nice find. It's possible I never tested that because the release-build-alpine build is so slow.
I guess the reason is that unlike before, $(ALPINE_TESTER) is not always an x86 image anymore. Instead, it's built for arm on arm machines. Will double check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, this cannot work. I added a helpful error message and ticket here: #483. First step would be to change the output file name in the Apline builder. But that's for another day.
810cfcc
to
5059f30
Compare
Pulled out of #478. Glad this is finally separated.