Update to cosmwasm 2.0.0-beta.0 #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
webmaster128
force-pushed
the
2.0.0-beta.0-release
branch
from
44e93dc
to
f4daa7b
Compare
webmaster128
reviewed
Jan 4, 2024
| /// | ||
| /// The order of the output elements is determined by the iteration order of the provided set. | ||
| fn set_to_csv(set: BTreeSet<impl AsRef<str>>) -> String { | ||
| let list: Vec<&str> = set.iter().map(|e| e.as_ref()).collect(); | ||
| list.join(",") |
There was a problem hiding this comment.
For the record, it seems like the intermediate vector can be avoided by using join from itertools. But since this is not on a hot path, we don't add the dependency for now.
https://stackoverflow.com/a/76223103/2013738
webmaster128
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Nice. I created #490 to break the whole topic down into small steps and get this merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 1 of #490