Cleanup build commands in Makefile #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
commented
Aug 12, 2024
| @@ -1,5 +1,3 @@ | |||
| .PHONY: all build build-rust build-go test | |||
There was a problem hiding this comment.
Decentralize .PHONY to avoid outdated list
| .PHONY: build | ||
| build: | ||
| make build-libwasmvm | ||
| make build-go |
There was a problem hiding this comment.
In the dependency notation we had before they may run in parallel (make build -j 2 would run both jobs at the same time)
| (cd libwasmvm && cargo build) | ||
| cp libwasmvm/target/debug/$(SHARED_LIB_SRC) internal/api/$(SHARED_LIB_DST) | ||
| make update-bindings | ||
|
|
||
| # use release build to actually ship - smaller and much faster | ||
| build-rust-release: | ||
| .PHONY: build-libwasmvm | ||
| build-libwasmvm: |
There was a problem hiding this comment.
We don't need two different commands for the release build
aumetra
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.