Skip to content

[Fix] Remove memory leak from sidebar #6596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[Fix] Remove memory leak from sidebar #6596

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a30c38
fix: clear timeouts and intervals before destroying sidebar component
gabrieloliveirapinto Aug 27, 2025
d1a05a3
feat: only set new timeout if it does not exist
gabrieloliveirapinto Aug 27, 2025
a3ab43d
Merge branch 'master' into fix-remove-memory-leak-from-sidebar
can-angun Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 64 additions & 23 deletions frontend/express/public/javascripts/countly/vue/components/sidebar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,6 +571,10 @@
},
data: function() {
return {
refsCheckInterval: null,
refsCheckTimeout: null,
onMainMenuMouseLeaveTimeout: null,
onOptionsMenuMouseLeaveTimeout: null,
selectedMenuOptionLocal: null,
versionInfo: countlyGlobal.countlyTypeName,
countlySidebarVersionPath: '/dashboard#/' + countlyCommon.ACTIVE_APP_ID + '/versions',
Expand Down Expand Up @@ -838,17 +842,22 @@
*/
this.$nextTick(function() {
this.$nextTick(function() {
setTimeout(function() {
if (selectedOption && selectedOption.menu === "dashboards") {
if (!self.onMainMenu && self.$refs.dashboards && self.$refs.dashboards[0] && !self.$refs.dashboards[0].hasOpenDrawer()) {
0;
/**
* If not on the main menu, hide the main menu.
*/
self.showMainMenu = false;
if (!self.onOptionsMenuMouseLeaveTimeout) {
self.onOptionsMenuMouseLeaveTimeout = setTimeout(function() {
if (selectedOption && selectedOption.menu === "dashboards") {
if (!self.onMainMenu && self.$refs.dashboards && self.$refs.dashboards[0] && !self.$refs.dashboards[0].hasOpenDrawer()) {
0;
/**
* If not on the main menu, hide the main menu.
*/
self.showMainMenu = false;
}
}
}
}, 0);

clearTimeout(self.onOptionsMenuMouseLeaveTimeout);
self.onOptionsMenuMouseLeaveTimeout = null;
}, 0);
}
});
});
},
Expand All @@ -871,16 +880,21 @@
*/
this.$nextTick(function() {
this.$nextTick(function() {
setTimeout(function() {
if (selectedOption && selectedOption.menu === "dashboards") {
if (!self.onOptionsMenu && self.$refs.dashboards && self.$refs.dashboards[0] && !self.$refs.dashboards[0].hasOpenDrawer()) {
/**
* If not on the options menu, hide the main menu.
*/
self.showMainMenu = false;
if (!self.onMainMenuMouseLeaveTimeout) {
self.onMainMenuMouseLeaveTimeout = setTimeout(function() {
if (selectedOption && selectedOption.menu === "dashboards") {
if (!self.onOptionsMenu && self.$refs.dashboards && self.$refs.dashboards[0] && !self.$refs.dashboards[0].hasOpenDrawer()) {
/**
* If not on the options menu, hide the main menu.
*/
self.showMainMenu = false;
}
}
}
}, 0);

clearTimeout(self.onMainMenuMouseLeaveTimeout);
self.onMainMenuMouseLeaveTimeout = null;
}, 0);
}
});
});
},
Expand Down Expand Up @@ -962,7 +976,7 @@
*
* Following technique of checking refs is just a fullproof way of doing it.
*/
setTimeout(function() {
this.refsCheckTimeout = setTimeout(function() {
self.$nextTick(function() {
self.$nextTick(function() {
/**
Expand All @@ -978,7 +992,7 @@
* Clear the interval when the refs are found.
*/
var counter = 0;
var interval = setInterval(function() {
self.refsCheckInterval = setInterval(function() {
if (counter > 10) {
/**
* Lets only check for the refs 10 times.
Expand All @@ -990,13 +1004,19 @@

// eslint-disable-next-line no-console
console.log("Refs not found in sidebar yet. Returning...");
clearInterval(interval);
clearTimeout(self.refsCheckTimeout);
clearInterval(self.refsCheckInterval);
self.refsCheckTimeout = null;
self.refsCheckInterval = null;
return;
}

if (Object.keys(self.$refs).length) {
self.identifySelected();
clearInterval(interval);
clearInterval(self.refsCheckInterval);
clearTimeout(self.refsCheckTimeout);
self.refsCheckTimeout = null;
self.refsCheckInterval = null;
}

counter++;
Expand All @@ -1006,6 +1026,27 @@
});
}, 0);
},
beforeDestroy() {
if (this.refsCheckInterval) {
clearInterval(this.refsCheckInterval);
this.refsCheckInterval = null;
}

if (this.onMainMenuMouseLeaveTimeout) {
clearTimeout(this.onMainMenuMouseLeaveTimeout);
this.onMainMenuMouseLeaveTimeout = null;
}

if (this.onOptionsMenuMouseLeaveTimeout) {
clearTimeout(this.onOptionsMenuMouseLeaveTimeout);
this.onOptionsMenuMouseLeaveTimeout = null;
}

if (this.refsCheckTimeout) {
clearTimeout(this.refsCheckTimeout);
this.refsCheckTimeout = null;
}
},
created: function() {
var self = this;
if (this.enableGuides) {
Expand Down
Loading