[sdk] Experimental section #6732
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+16
to
+17
| return str.replace(/"/g, '"') | ||
| .replace(/&/g, '&') |
Check failure
Code scanning / CodeQL
Double escaping or unescaping High test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 15 hours ago
To fix the double unescaping problem, we need to reorder the replacements in the unescapeHtml function. Specifically, all replacements that introduce ampersands (&) should be performed after other entity replacements. This means the unescaping for & must occur after unescaping ", <, >, and '. Therefore, modify the function in plugins/sdk/tests/validation_tests.js at line 16-20 so that .replace(/&/g, '&') is done last. No extra imports or definitions are needed for native JS replace.
Suggested changeset
1
plugins/sdk/tests/validation_tests.js
| @@ -14,10 +14,10 @@ | ||
| return str; | ||
| } | ||
| return str.replace(/"/g, '"') | ||
| .replace(/&/g, '&') | ||
| .replace(/</g, '<') | ||
| .replace(/>/g, '>') | ||
| .replace(/'/g, "'"); | ||
| .replace(/'/g, "'") | ||
| .replace(/&/g, '&'); | ||
| } | ||
| before(function(done) { | ||
| const enforcement = { |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.