Tracking PR for the godot-cpp cmake changes#829
Closed
enetheru wants to merge 1 commit intoCraterCrash:2.1from
Closed
Tracking PR for the godot-cpp cmake changes#829enetheru wants to merge 1 commit intoCraterCrash:2.1from
enetheru wants to merge 1 commit intoCraterCrash:2.1from
Conversation
enetheru
force-pushed
the
2.1-modernise
branch
from
ebef83b to
616fa3d
Compare
Some changes are just for testing .gitignore cmake-build* .gitmodules point to my cherry picked branch Commented out engine fetching and building Get platform, target, and arch tags from godot-cpp remove godot-cpp from cmake module path remove build flags, all inherited from godot-cpp now
enetheru
force-pushed
the
2.1-modernise
branch
from
616fa3d to
4b45bf6
Compare
Member
|
Hi @enetheru did you intend to delete this? |
Author
|
Sorry yeah, I started again. |
Author
|
Here is the second attempt branch https://github.com/enetheru/godot-orchestrator/tree/gdext-4.4 There was one line that was concerning and that was src/script/serialization/text_loader_instance.cpp:887 which fails to compile |
Member
|
I'll take a look. I believe the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
These cmake changes track the changes Ive been making over at godot-cpp PR:1598
This is one of the only projects that uses cmake that I can verify my changes with.
If you find them interesting I would appreciate any feedback you can profile.
Cheers,
Samuel.