Client-side remove package from hand when put on chain #8601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forces mainhand package to be instantly removed from the mainhand when placing it on a chain conveyor This is more of a failsafe to prevent the player from putting the package on the chain multiple times
VoidLeech
added
pr type: fix
-Lazy updating during SEARCH_INPUTS phase so as to not make the arm search for targets on every tick. This should help with performance with many arms or arms that have lots of targets -Replaced if-else-if blocks that checked the arm's Phase with Switch statements -Cached getSlotCount result for arm interaction point slot iterations, should help when iterating high slot counts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forces mainhand package to be instantly removed from the mainhand when placing it on a chain conveyor to prevent any potential duping
This fixes (for survival mode atleast) a weird compatibility issue with Epicfight, where
InputEvents.onClickInputis executed twice, which dupes the package. This seems to be a bigger issue in itself and i don't think that's in the scope of this pull request. I have instead posted more about that issue on the Create Discord in this message: https://discord.com/channels/620934202875183104/689866656914210897/1379140295165476945