Skip to content

Fix claim protection bypass and possible packet exploits with BlockEntityConfigurationPacket #8663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: mc1.21.1/dev
Choose a base branch
from
Open

Fix claim protection bypass and possible packet exploits with BlockEntityConfigurationPacket #8663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a49bd41
Check if the player can interact with the target block in BlockEntity…
juanmuscaria Jun 11, 2025
f71c47f
Fix Sequenced Gearshift packet exploit allowing malicious players to …
juanmuscaria Jun 11, 2025
96ac083
Code style change
juanmuscaria Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ubi/create/content/kinetics/transmission/sequencer/ConfigureSequencedGearshiftPacket.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public ConfigureSequencedGearshiftPacket(BlockPos pos, Vector<Instruction> instr

@Override
protected void applySettings(ServerPlayer player, SequencedGearshiftBlockEntity be) {
if (be.computerBehaviour.hasAttachedComputer())
if (be.computerBehaviour.hasAttachedComputer() || this.instructions.size() > 5)
return;

be.run(-1);
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/simibubi/create/foundation/codec/CreateStreamCodecs.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public interface CreateStreamCodecs {
*/
@Deprecated(forRemoval = true)
static <B extends ByteBuf, V> StreamCodec.CodecOperation<B, V, Vector<V>> vector() {
return codec -> ByteBufCodecs.collection(Vector::new, codec);
return codec -> ByteBufCodecs.collection(Vector::new, codec, 256);
}

/**
Expand Down
11 changes: 11 additions & 0 deletions src/main/java/com/simibubi/create/foundation/networking/BlockEntityConfigurationPacket.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,17 @@

import net.minecraft.core.BlockPos;
import net.minecraft.server.level.ServerPlayer;
import net.minecraft.world.InteractionHand;
import net.minecraft.world.level.Level;
import net.minecraft.world.level.block.entity.BlockEntity;

import net.minecraft.world.phys.BlockHitResult;

import net.minecraft.world.phys.Vec3;

import net.neoforged.neoforge.common.CommonHooks;
import net.neoforged.neoforge.event.entity.player.PlayerInteractEvent;


public abstract class BlockEntityConfigurationPacket<BE extends SyncedBlockEntity> implements ServerboundPacketPayload {
protected final BlockPos pos;
Expand All @@ -30,6 +38,9 @@ public void handle(ServerPlayer player) {
return;
BlockEntity blockEntity = world.getBlockEntity(this.pos);
if (blockEntity instanceof SyncedBlockEntity) {
PlayerInteractEvent.RightClickBlock result = CommonHooks.onRightClickBlock(player, InteractionHand.MAIN_HAND, this.pos, new BlockHitResult(Vec3.atCenterOf(this.pos), player.getDirection().getOpposite(), this.pos, true));
if (result.isCanceled())
return;
applySettings(player, (BE) blockEntity);
if (!causeUpdate())
return;
Expand Down