Skip to content

fixed threshold switch not counting stacks correctly. #8797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: mc1.20.1/dev
Choose a base branch
from
Open

fixed threshold switch not counting stacks correctly. #8797

wants to merge 2 commits into from

Conversation

sssxks
Copy link

@sssxks sssxks commented Jun 26, 2025

fix: #7688 (comment)

behavior changed:

  • item measure mode has the same behavior as before
  • stack measure mode measures stacks, if count is equal to the space
  • reinterpreted BlockEntity data, may cause backward compatibility issue
    • maybe implement an one-time migration?
  • fluid tank, custom has the same behavior as before

previous pr targeted a wrong branch, so i cherrypicked the code here

@VoidLeech VoidLeech added the pr type: fix PR fixes a bug label Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr type: fix PR fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Threshold Switch incorrectly showing maximum capacity (max stack/items)
2 participants
@sssxks @VoidLeech