Skip to content

Fix proposal for #6076 #9256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: mc1.20.1/dev
Choose a base branch
from
Open

Fix proposal for #6076 #9256

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d9f1f30
bye schematilag
Allmoz Sep 17, 2025
cb0d59b
be consistent
Allmoz Sep 17, 2025
eabb84b
added tooltip hint about being disabled
Allmoz Sep 19, 2025
fa1cf0c
sure, why not, always can rebase
Allmoz Sep 19, 2025
96050c6
de-ups
Allmoz Sep 19, 2025
395f38a
clean up
Allmoz Sep 19, 2025
2b31d83
finaly, datagen and no .cache
Allmoz Sep 19, 2025
ba90f99
ABCDEFG...
Allmoz Sep 19, 2025
ceb4a25
hope this is
Allmoz Sep 19, 2025
f703702
Merge branch 'mc1.20.1/dev' into schemati_lag
Allmoz Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/main/java/com/simibubi/create/content/schematics/cannon/SchematicannonScreen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ public class SchematicannonScreen extends AbstractSimiContainerScreen<Schematica

private final String _slotGunpowder = "gui.schematicannon.slot.gunpowder";
private final String _slotListPrinter = "gui.schematicannon.slot.listPrinter";
private final String _slotSchematic = "gui.schematicannon.slot.schematic";
private final String _slotSchematicEnabled = "gui.schematicannon.slot.schematic";
Copy link
Contributor Author

@Allmoz Allmoz Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I migrate it to "gui.schematicannon.slot.schematicEnabled"? is enough just changing the id?

private final String _slotSchematicDisabled = "gui.schematicannon.slot.schematicDisabled";

private final Component optionEnabled = CreateLang.translateDirect("gui.schematicannon.optionEnabled");
private final Component optionDisabled = CreateLang.translateDirect("gui.schematicannon.optionDisabled");
Expand Down Expand Up @@ -292,6 +293,10 @@ protected void renderBg(GuiGraphics graphics, float partialTicks, int mouseX, in
.isEmpty())
renderBlueprintHighlight(graphics, x, y);

//if (!be.inventory.getStackInSlot(1)
// .isEmpty())
// renderBlueprintAlertHighlight(graphics, x, y);

GuiGameElement.of(renderedItem).<GuiGameElement
.GuiRenderBuilder>at(x + BG_TOP.getWidth(), y + BG_TOP.getHeight() + BG_BOTTOM.getHeight() - 48, -200)
.scale(5)
Expand Down Expand Up @@ -321,6 +326,10 @@ protected void renderBlueprintHighlight(GuiGraphics graphics, int x, int y) {
AllGuiTextures.SCHEMATICANNON_HIGHLIGHT.render(graphics, x + 10, y + 60);
}

//protected void renderBlueprintAlertHighlight(GuiGraphics graphics, int x, int y) {
// AllGuiTextures.SCHEMATICANNON_ALERT_HIGHLIGHT.render(graphics, x + 10, y + 60);
//}

protected void renderPrintingProgress(GuiGraphics graphics, int x, int y, float progress) {
progress = Math.min(progress, 1);
AllGuiTextures sprite = AllGuiTextures.SCHEMATICANNON_PROGRESS;
Expand Down Expand Up @@ -357,10 +366,12 @@ protected void renderForeground(GuiGraphics graphics, int mouseX, int mouseY, fl
}

if (hoveredSlot != null && !hoveredSlot.hasItem()) {
if (hoveredSlot.index == 0)
if (hoveredSlot.index == 0) {
boolean enabled = be.inventory.getStackInSlot(1).isEmpty();
graphics.renderComponentTooltip(font,
TooltipHelper.cutTextComponent(CreateLang.translateDirect(_slotSchematic), Palette.GRAY_AND_BLUE), mouseX,
mouseY);
TooltipHelper.cutTextComponent(CreateLang.translateDirect(enabled ? _slotSchematicEnabled :_slotSchematicDisabled),
Palette.GRAY_AND_BLUE), mouseX, mouseY);
}
if (hoveredSlot.index == 2)
graphics.renderComponentTooltip(font,
TooltipHelper.cutTextComponent(CreateLang.translateDirect(_slotListPrinter), Palette.GRAY_AND_BLUE),
Expand Down
1 change: 1 addition & 0 deletions src/main/java/com/simibubi/create/foundation/gui/AllGuiTextures.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ public enum AllGuiTextures implements ScreenElement, TextureSheetSegment {
SCHEMATICANNON_PROGRESS("schematics_2", 76, 239, 114, 16),
SCHEMATICANNON_CHECKLIST_PROGRESS("schematics_2", 191, 240, 16, 14),
SCHEMATICANNON_HIGHLIGHT("schematics_2", 1, 229, 26, 26),
SCHEMATICANNON_ALERT_HIGHLIGHT("schematics_2", 1, 229, 26, 26),
SCHEMATICANNON_FUEL("schematics_2", 28, 222, 47, 16),
SCHEMATICANNON_FUEL_CREATIVE("schematics_2", 28, 239, 47, 16),

Expand Down
Loading