Fix filter inconsistencies when filtering filters #9294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes package filters with an empty address string still accepting package filters.
Fixes attribute filters with empty attribute lists always and only accepting attribute filters, irrespective of whitelist mode (doesn't match traditional definitions of 'matches any', 'matches all', and 'not matches any' which would result in nothing, everything, everything)
Fixes - #5017 by undoing 'Fixed Filters and Attribute Filters not stacking with unmodified, equivalent stacks' from ffa85dc, because that also led to:
Fixes empty list filters on allow mode and ignore data(per the allow-mode summary, this should reject everything) still accepting list filters in the existing code for FilterItemStack, there is a meaningful difference between 'stack has no nbt' and 'stack has the default value as nbt', but the latter is currently unobtainable:
Create/src/main/java/com/simibubi/create/content/logistics/filter/FilterItemStack.java
Lines 26 to 33 in 880ec94