Implement Monotonic Interest Index with Tests and Documentation#204
Open
icodeBisola wants to merge 5 commits intoCredenceOrg:mainfrom
Open
Implement Monotonic Interest Index with Tests and Documentation#204icodeBisola wants to merge 5 commits intoCredenceOrg:mainfrom
icodeBisola wants to merge 5 commits intoCredenceOrg:mainfrom
Conversation
- Introduced a new module for calculating and enforcing a monotonic interest index to prevent accrual anomalies. - Added functions for calculating the new index based on elapsed time and interest rate, ensuring non-decreasing behavior. - Implemented ceiling division to handle precision loss and prevent backward movement of the index. - Created comprehensive unit tests covering basic functionality, edge cases, and regression scenarios. - Added documentation detailing the index's properties, calculation methods, and usage examples. test: Add tests for grace window functionality in signed orders - Developed tests for configurable post-deadline grace window behavior. - Covered scenarios including strict mode acceptance, grace window acceptance, and replay protection. - Ensured unauthorized changes to the grace window are properly restricted. test: Create extensive tests for monotonic interest index - Added a suite of tests to validate the monotonic interest index implementation. - Included property-based tests to ensure consistent non-decreasing behavior across various inputs. - Implemented regression tests for previously identified precision loss issues and edge cases. docs: Add documentation for Monotonic Interest Index - Created a detailed markdown document explaining the Monotonic Interest Index. - Included sections on index representation, calculatstrategies. - Pfix
|
@icodeBisola Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #143
Close #156
Close #166