Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jupyter collaboration ext #107

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Add jupyter collaboration ext #107

merged 2 commits into from
Jan 30, 2024

Conversation

tsnow03
Copy link
Member

@tsnow03 tsnow03 commented Jan 29, 2024

Testing to see if opening and closing a notebook with jupyter-collaboration installed makes the save button work.

@github-actions GitHub Actions
Copy link

Binder 👈 Test this PR on Binder

@tsnow03 tsnow03 mentioned this pull request Jan 29, 2024
Open
@tsnow03 tsnow03 marked this pull request as draft January 29, 2024 05:39
@tsnow03
Copy link
Member Author

tsnow03 commented Jan 29, 2024 •
edited
Loading

Save button is still out of commission. Checking with developers now on this one.

@tsnow03 tsnow03 marked this pull request as ready for review January 29, 2024 14:53
@tsnow03 tsnow03 requested a review from weiji14 January 29, 2024 14:54
@tsnow03
Copy link
Member Author

tsnow03 commented Jan 29, 2024 •
edited
Loading

Using jupyter-collaboration is meant to turn off the save buttons. Saving is automatic as changes are made or the notebook is closed. If a notebook was left open from a previous session where collaboration was not enabled, you may need to close and reopen the notebook if it isn't saving. I opened and closed multiple notebooks and it seemed to work perfectly so far. It however, doesn't always tell you it is saved until after you close it so it will probably be a little unnerving at first. It is set to go and working properly though.

wsauthoff
wsauthoff reviewed Jan 30, 2024
View reviewed changes
environment.yml Outdated
@@ -32,7 +32,7 @@ dependencies:
- jupyter-ai~=2.9.1
- jupyter-book~=0.15.1
# - jupyter-offlinenotebook~=0.2.2 # Outdated according to jupyterlab
# - jupyter-collaboration~=2.0.1 # Causing save issues
- jupyter-collaboration~=2.0.1 # Causing save issues
Copy link
Member

@wsauthoff wsauthoff Jan 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps you should remove the "# Causing save issues" comment since it seems to be working after testing? i want to minimize confusion down the road.

wsauthoff
wsauthoff approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@wsauthoff wsauthoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binder demo seems to work well for the collaboration feature. great addition to the image!

@tsnow03
Copy link
Member Author

tsnow03 commented Jan 30, 2024

/condalock

@tsnow03
Copy link
Member Author

tsnow03 commented Jan 30, 2024

Thanks for the review @wsauthoff! Now for user testing with the docker image...

@tsnow03 tsnow03 merged commit eceb8f9 into main Jan 30, 2024
1 check passed
@tsnow03 tsnow03 deleted the collab branch January 30, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsauthoff wsauthoff wsauthoff approved these changes

@weiji14 weiji14 Awaiting requested review from weiji14

@jdmillstein jdmillstein Awaiting requested review from jdmillstein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsnow03 @wsauthoff