MTM-61884: Change log for tenant context operation api #2805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vartikarai04
requested review from
scmi-c8y,
rohitjoshi-c8y,
gapa-c8y and
schmiel-cumulocity
|
Preview available here |
scmi-c8y
reviewed
Jan 14, 2025
...ange-logs/analytics/cumulocity-undefined-notifications-tenant-context-operations-wildcard.md
Outdated
Show resolved
Hide resolved
...ange-logs/analytics/cumulocity-undefined-notifications-tenant-context-operations-wildcard.md
Outdated
Show resolved
Hide resolved
...ange-logs/analytics/cumulocity-undefined-notifications-tenant-context-operations-wildcard.md
Outdated
Show resolved
Hide resolved
Review comment changes Co-authored-by: Scott Mitchell <[email protected]>
scmi-c8y
approved these changes
Jan 15, 2025
…e' of github.com:Cumulocity-IoT/c8y-docs into feature/MTM-61884/notitification2.0_operation_api_update
gapa-c8y
approved these changes
Jan 16, 2025
scmi-c8y
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Sorry to again request changes. I finally found the new location of the process documentation and spotted a few more things that should be changed.
I would also move this out of draft status so that e.g. Beate and Jane know they should look at it.
...ange-logs/analytics/cumulocity-undefined-notifications-tenant-context-operations-wildcard.md
Outdated
Show resolved
Hide resolved
...ange-logs/analytics/cumulocity-undefined-notifications-tenant-context-operations-wildcard.md
Show resolved
Hide resolved
...ogs/platform-services/cumulocity-undefined-notifications-tenant-context-event-type-filter.md
Outdated
Show resolved
Hide resolved
...ogs/platform-services/cumulocity-undefined-notifications-tenant-context-event-type-filter.md
Show resolved
Hide resolved
...ogs/platform-services/cumulocity-undefined-notifications-tenant-context-event-type-filter.md
Outdated
Show resolved
Hide resolved
...ogs/platform-services/cumulocity-undefined-notifications-tenant-context-event-type-filter.md
Outdated
Show resolved
Hide resolved
...ogs/platform-services/cumulocity-undefined-notifications-tenant-context-event-type-filter.md
Outdated
Show resolved
Hide resolved
scmi-c8y
requested changes
Jan 20, 2025
There was a problem hiding this comment.
Just a few minor (although important) things remaining IMHO. I also think this should be moved out of draft status so that the doc team will also review it.
NOTE: The second CL, for the events change, will also need to be grafted to 2025. Apologies for not mentioning this earlier (I managed to confuse myself about which changes needed to be mentioned in which releases)
...ogs/platform-services/cumulocity-undefined-notifications-tenant-context-event-type-filter.md
Outdated
Show resolved
Hide resolved
...ogs/platform-services/cumulocity-undefined-notifications-tenant-context-event-type-filter.md
Outdated
Show resolved
Hide resolved
...ange-logs/analytics/cumulocity-undefined-notifications-tenant-context-operations-wildcard.md
Outdated
Show resolved
Hide resolved
...ogs/platform-services/cumulocity-undefined-notifications-tenant-context-event-type-filter.md
Outdated
Show resolved
Hide resolved
vartikarai04
requested review from
iiar-c8y,
martin-c8y,
mgrumann,
saran-govindarajan,
kowa-c8y,
JanePorter,
BeateRixen and
MWindel
as code owners
scmi-c8y
approved these changes
Jan 21, 2025
BeateRixen
reviewed
Jan 21, 2025
...ange-logs/analytics/cumulocity-undefined-notifications-tenant-context-operations-wildcard.md
Outdated
Show resolved
Hide resolved
...ange-logs/analytics/cumulocity-undefined-notifications-tenant-context-operations-wildcard.md
Outdated
Show resolved
Hide resolved
...ogs/platform-services/cumulocity-undefined-notifications-tenant-context-event-type-filter.md
Outdated
Show resolved
Hide resolved
...ogs/platform-services/cumulocity-undefined-notifications-tenant-context-event-type-filter.md
Outdated
Show resolved
Hide resolved
...ogs/platform-services/cumulocity-undefined-notifications-tenant-context-event-type-filter.md
Outdated
Show resolved
Hide resolved
Review comment changes Co-authored-by: Beate Rixen <[email protected]>
BeateRixen
approved these changes
Jan 21, 2025
schmiel-cumulocity
approved these changes
Jan 21, 2025
vartikarai04
deleted the
feature/MTM-61884/notitification2.0_operation_api_update
branch
vartikarai04
added a commit
that referenced
this pull request
Jan 27, 2025
…fication2.0_operation_api_update MTM-61884: Change log for tenant context operation api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log PR willl be merged after the build that enables the feature is deployed to Zone 1