Fix New GUI Input Breakage#1735
Merged
LukeUsher merged 2 commits intoSep 28, 2019
Merged
Conversation
Member
Author
|
|
ab02e50 to
52da59e
Compare
LukeUsher
approved these changes
Sep 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes are to fix #1713 pull request to able allow loader's emulator project to compile. Since some includes were not meant for emulation usage. And moved emulation codes into proper common files.
Plus move SDL2 linkage directly into target_link_libraries, CMake, call since SDL2 is not Windows only platform. 😉