Another approach for fixing subscription leak #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtryfoss
commented
Jul 2, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion
a discussion (no related file):
Might need some locking before manipulating busWrapper.subs now.
mtryfoss
commented
Jul 2, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion
a discussion (no related file):
busWrapper
I meant subBus
mtryfoss
commented
Jul 2, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion
a discussion (no related file):
Previously, mtryfoss wrote…
busWrapper
I meant subBus
Tested with about 4000 generated calls and no sign of any leak as far as I can see.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on your feedback yesterday. There's also a pull request on ari/stdbus.
This code is not that well tested yet, but seems promising so far.
This change is