Chore/sc 36142/upgrade angular from 17 to 18 on clark client #2138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a character counter Disable submit when it reaches past that counter
joaquinVill
changed the base branch from
main
to
chore/sc-36141/upgrade-angular-from-16-to-17-on-clark-client
Co-authored-by: Copilot <[email protected]>
…r-from-16-to-17-on-clark-client Chore/sc 36141/upgrade angular from 16 to 17 on clark client
…eci-config-yml-for-clark-client feature/sc-38596/update-circleci-config-yml-for-clark-client
…eci-config-yml-for-clark-client upload source maps moved under jobs
…t-rating-error-message rating character limit
…-deployment-1-22-26 feature/sc-38598/clark-client-deployment-1-22-26
This was painful. Client really needs a rewrite
Add an actions column for the preview and download functionality
…t-when-the-learning-object chore/sc-38582/disable-chatbot-when-the-learning-object
…le-previewer-for-microsoft Implement file previewer for Office files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything went pretty smoothly with this update. The only issue I came across was that Angular 18’s stricter TS checks now flag using injected services in field initializers. I had to move
UntypedFormGroupconstruction into the constructor so the dependent services are initialized before the forms are created.