Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/Borealis (master) #1293

Merged
merged 7 commits into from
Dec 9, 2024
Merged

Update/Borealis (master) #1293

merged 7 commits into from
Dec 9, 2024

Conversation

cccs-nr
Copy link
Contributor

@cccs-nr cccs-nr commented Oct 22, 2024

Added the publicIconify and customIconify properties to borealis by passing them from the /whoami configuration.

@cccs-nr cccs-nr requested a review from cccs-rs October 22, 2024 17:59
@cccs-nr cccs-nr self-assigned this Oct 22, 2024
@cccs-nr
Copy link
Contributor Author

cccs-nr commented Oct 23, 2024

Note. on borealis version 0.2.2, this current implementation is causing a crash where the borealis component doesn't exist in the scope of the drawer. The new iconify properties are being set from the /whoami call as props to the borealis provider. This change needs to be reverted and those properties be set from within the provider.

@cccs-nr cccs-nr merged commit 483565f into master Dec 9, 2024
1 check passed
@cccs-nr cccs-nr deleted the update/borealis branch December 9, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants