Add 5 Metrics for AMOE#114
Draft
lebogg wants to merge 30 commits into
Draft
Conversation
Open
* Add metric for PasswordRotationFrequency * Add review comments * Add merged ontology file [skip ci] * Rename PasswordRotationFrequency to RotationFrequency; Update metric * Add rotationFrequency to Authenticity * Add merged ontology file [skip ci] * Add generated proto file [skip ci] * Update metric and targetValue * Update metric to check hours instead of a bool * Add deleted yml file * Add rotationFrequency to Authenticity * Add merged ontology file [skip ci] * Add generated proto file [skip ci] * Rename rotationFrequency -> rotationInterval * Add merged ontology file [skip ci] * Add generated proto file [skip ci] * Add merged ontology file [skip ci] * Add generated proto file [skip ci] * Rename RotationFrequency -> PasswordRotationFrequency * Update metric passwordRotationInterval * Reaname * Fix comment * Add comment to ontology * ++ * ++ * Add merged ontology file [skip ci] * Add generated proto file [skip ci] * Fix rotation interval comment * Add merged ontology file [skip ci] * Add generated proto file [skip ci] * Fix typos * Fix path * Fix format; Check all resources, not only policy documents * ++ * Remove comma * Add category --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Nico Haas <nico.haas@aisec.fraunhofer.de> Co-authored-by: Nico Haas <40119051+lebogg@users.noreply.github.com>
* Add metric yml, rego and data * Update ontology * Add merged ontology file [skip ci] * Add generated proto file [skip ci] * Add `gitattributes` file * Update gitattributes * Fix gitattributes * Add metric PasswordRotationInterval (#91) * Add metric for PasswordRotationFrequency * Add review comments * Add merged ontology file [skip ci] * Rename PasswordRotationFrequency to RotationFrequency; Update metric * Add rotationFrequency to Authenticity * Add merged ontology file [skip ci] * Add generated proto file [skip ci] * Update metric and targetValue * Update metric to check hours instead of a bool * Add deleted yml file * Add rotationFrequency to Authenticity * Add merged ontology file [skip ci] * Add generated proto file [skip ci] * Rename rotationFrequency -> rotationInterval * Add merged ontology file [skip ci] * Add generated proto file [skip ci] * Add merged ontology file [skip ci] * Add generated proto file [skip ci] * Rename RotationFrequency -> PasswordRotationFrequency * Update metric passwordRotationInterval * Reaname * Fix comment * Add comment to ontology * ++ * ++ * Add merged ontology file [skip ci] * Add generated proto file [skip ci] * Fix rotation interval comment * Add merged ontology file [skip ci] * Add generated proto file [skip ci] * Fix typos * Fix path * Fix format; Check all resources, not only policy documents * ++ * Remove comma * Add category --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Nico Haas <nico.haas@aisec.fraunhofer.de> Co-authored-by: Nico Haas <40119051+lebogg@users.noreply.github.com> * save ontology file * Fix metric * Fix metric * Ontology fix: Move feature to security owx * Ontology: Use `scanInterval` as feature name * Add merged ontology file [skip ci] * Add generated proto file [skip ci] * Update metrics/LoggingMonitoring/AntimalwareScanFrequency/AntimalwareScanFrequency.yml Co-authored-by: Angelika Schneider <aruppel@gmx.de> * Update metrics/LoggingMonitoring/AntimalwareScanFrequency/metric.rego Co-authored-by: Angelika Schneider <aruppel@gmx.de> --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Angelika Schneider <aruppel@gmx.de>
* Add data, metric and yml * Ontology: Add length to password security feature * Add merged ontology file [skip ci] * Add generated proto file [skip ci] * Use normal int * Add merged ontology file [skip ci] * Add generated proto file [skip ci] * Add category * Use actual AMOE question from XLS * Add "default" to comment * Move `length` feature to security owx * Remove target value from comment * Add merged ontology file [skip ci] * Add generated proto file [skip ci] * Add keywords * Revert keyword field. Add it in another PR * Fix string * Fix AMOE field * Update target value for password characters from 5 to 8 * Move lentgth to Authenticity, so that all underlying classes can use the length property * Add merged ontology file [skip ci] * Add generated proto file [skip ci] --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Angelika Schneider <aruppel@gmx.de> Co-authored-by: Angelika Schneider <angelika.schneider@aisec.fraunhofer.de>
anatheka
reviewed
Jan 29, 2026
| configuration: | ||
| p1: | ||
| operator: "<=" | ||
| targetValue: 10 # in days? (TODO) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #90