Conversation
* init pilot 4 metrics * feat(pilot4metrics): integrate pilot 4 metric additions Sort pilot 4 metrics into existing/new category folders under metrics/: - metrics/AssetManagement/ (AssetInventoryEnabled, AssetInventoryReviewFrequency) - metrics/Backup/ (BackupFrequency, BackupRecoveryFrequency) - metrics/SecurityIncidents/ (IncidentReportingTeam) Align YAMLs (UUIDs, category names) and rego files (snake_case package, lowerCamelCase document properties, applicable existence check, message rules) with pilot 2 conventions. Extend ontology following the pilot 2 pattern: - Declare cl:AssetInventory, cl:Backup, cl:CloudFeature, cl:SecurityIncident in document.owx and attach them to cl:PolicyDocument via prop:has - cl:AssetInventory/cl:Backup subclass the existing core:* counterparts - Add data property axioms: reviewFrequency, frequency, recoveryFrequency, property, team - Declare and label the new res:* data properties in core/properties.owx Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * Add metric `RestrictSSH` * Add metric `VirtualMachinePublicIpDisabled` * Use new ID * Fix name of metric * fix(ontology): remove self-loop SubClassOf for AssetInventory/Backup In document.owx, the cl:, res:, and core: prefixes all resolve to the same /classes/ IRI, so `cl:AssetInventory ⊆ core:AssetInventory` and `cl:Backup ⊆ core:Backup` were X ⊆ X self-loops, which crashed owl2proto's findAllLeafs with a stack overflow. Attach the new data properties (prop:reviewFrequency, prop:frequency, prop:recoveryFrequency) directly to core:AssetInventory / core:Backup and drop the redundant cl: declarations. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Christian Banse <christian.banse@aisec.fraunhofer.de> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com> Co-authored-by: Angelika Schneider <angelika.schneider@aisec.fraunhofer.de> Co-authored-by: Nico Haas <nico.haas@aisec.fraunhofer.de>
NetworkSecurity/VirtualMachinePublicIpDisabled
oxisto
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the EMERALD pilot 4 metrics and a fix for metric
NetworkSecurity/VirtualMachinePublicIpDisabled.