-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cyclonedx.model.dependency.Dependency.provides
#735
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Uzair Chhapra <[email protected]>
f2ad0ed
to
fb4598d
Compare
Signed-off-by: Uzair Chhapra <[email protected]>
@jkowalleck PR is ready for review. |
cyclonedx.model.dependency.Dependency.provides
cyclonedx.model.dependency.Dependency.provides
thank you for your contribution, @uzairchhapra . the implementation looks promising. Regarding tests, we tend to go with an integration-test snapshot-solution, over detailed unit tests. |
Signed-off-by: Uzair Chhapra <[email protected]>
Signed-off-by: Uzair Chhapra <[email protected]>
Signed-off-by: Uzair Chhapra <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
self, | ||
target: Dependable, | ||
depends_on: Optional[Iterable[Dependable]] = None, | ||
provides: Optional[Iterable[Dependable]] = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of adding a new parameter here, how about adding a new method instead: register_provision(self, target: Dependable, provides: Optional[Iterable[Dependable]] = None)
.
what do you think about this?
this would fit the original architectural plans better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll give this a try
Signed-off-by: Uzair Chhapra <[email protected]>
@@ -1310,6 +1310,28 @@ def get_bom_with_definitions_standards() -> Bom: | |||
) | |||
|
|||
|
|||
def get_bom_v1_6_with_provides() -> Bom: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please rename to get_bom_with_provides
.
there is no intention to have models for certain CDX versions only.
In fact, it is intended to test the serialization with a target that is expected to omit certain parts.
@uzairchhapra, I just wanted to ask how things are going. |
Apologies for the delayed response. I will get to this this weekend. If I remember correctly, I was stuck in making the test function work |
Fixes #691