fix: bc-verify-broadcast also matches CREATE2/CREATE3 ContractCreation events#6
Open
PickleyD wants to merge 1 commit intoCyfrin:mainfrom
Open
fix: bc-verify-broadcast also matches CREATE2/CREATE3 ContractCreation events#6PickleyD wants to merge 1 commit intoCyfrin:mainfrom
PickleyD wants to merge 1 commit intoCyfrin:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bc-verify-broadcastwas only matching CreateX's single-argContractCreation(address indexed)event (topic0x4db17dd5...), which is emitted bydeployCreate. CreateX'sdeployCreate2anddeployCreate3emit a different two-arg eventContractCreation(address indexed, bytes32 indexed)(topic0xb8fda7e0...), so any contract deployed via CREATE2/CREATE3 was silently skipped during verification.This was discovered while walking the battlechain-starter-foundry quickstart:
just verify-setuponly verifiedMockToken(deployed viabcDeployCreate) and silently skippedVulnerableVault(deployed viabcDeployCreate2).