Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces the core logic for converting modpack instances into Modrinth .mrpack archives and adds supporting filesystem/ZIP utilities, while cleaning up IDE-specific project files from version control.
Changes:
- Added
Converterto locate a launcher instance inside an extracted modpack, generate a Modrinth manifest, copy instance files (with ignore rules), and package the result as a.mrpack. - Introduced
ZipUtilandFileUtilhelpers for zipping/unzipping directories and copying files/directories recursively. - Simplified IDE metadata handling by ignoring the entire
.ideadirectory in.gitignoreand removing committed IDEA configuration files; slightly adjustedMainto allow IO operations.
Reviewed changes
Copilot reviewed 4 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/main/java/org/ceciliastudio/modpackconverter/Converter.java |
Implements end-to-end conversion pipeline (instance discovery, manifest generation, file copying, and final archive creation). |
src/main/java/org/ceciliastudio/modpackconverter/util/ZipUtil.java |
Provides ZIP archive creation and extraction utilities used by the converter. |
src/main/java/org/ceciliastudio/modpackconverter/util/FileUtil.java |
Adds recursive copy utilities to move instance contents into the Modrinth overrides structure. |
src/main/java/org/ceciliastudio/modpackconverter/Main.java |
Prepares the entry point for IO-based operations by allowing IOException to be thrown (currently still a simple stub). |
.gitignore |
Broadens ignore rules to exclude all .idea project files from version control. |
.idea/* |
Removes previously committed IntelliJ IDEA project configuration files in favor of ignoring them. |
Files not reviewed (7)
- .idea/.gitignore: Language not supported
- .idea/.name: Language not supported
- .idea/dictionaries/project.xml: Language not supported
- .idea/gradle.xml: Language not supported
- .idea/material_theme_project_new.xml: Language not supported
- .idea/misc.xml: Language not supported
- .idea/vcs.xml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/org/ceciliastudio/modpackconverter/util/ZipUtil.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.